Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Read case sensitive CONFIG #192

Merged
merged 1 commit into from
Apr 4, 2021

Conversation

mchill
Copy link
Contributor

@mchill mchill commented Apr 4, 2021

Read the case sensitive value of the config file when using the CONFIG environment variable.
Converting the string to lowercase breaks case sensitive api keys/secrets for GoDaddy (and possibly
other providers).

Signed-off-by: Matthew Hill matthewchill7@gmail.com

Possibly solves #91.

Read the case sensitive value of the config file when using the CONFIG environment variable.
Converting the string to lowercase breaks case sensitive api keys/secrets for GoDaddy (and possibly
other providers).

Signed-off-by: Matthew Hill <matthewchill7@gmail.com>
Copy link
Owner

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You totally solved that, thanks! Plus good job on finding that case sensitive option 👍

@qdm12 qdm12 merged commit c0e57c6 into qdm12:master Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants