add: porkbun provider

[fredericrous]

resolves #216

[fredericrous]

lol, I broke your github action @qdm12

[qdm12]

lol, I broke your github action @qdm12

😄 yes it's because of the branch name, docker tags don't accept /

As in it passed the verify stage so that's what matters mostly. I'll review your code now, thanks for the contribution!

[qdm12]

Nice thanks for the contribution! A few comments, hopefully it's not too much 😉

[fredericrous]

Thanks for the review, I'll continue to integrate these feedbacks this evening.
Regarding the container tag. Is this bach? we could do something like echo ::set-output name=version::${TAG##*/} on line 77 there:

ddns-updater/.github/workflows/build.yml

Line 77 in bc1a5b2

echo ::set-output name=version::$TAG

[qdm12]

Is this bach? we could do something like echo ::set-output name=version::${TAG##*/} on line 77 there:

Yes it's bash, but instead try to not use slashes in branches next time 😉

It brings a whole load of problems for git, go etc. I don't recall exactly what it was but it was terrible, another example

EDIT: Well it doesn't hurt to fix the CI still so the CI passes here. Note however it's on line

ddns-updater/.github/workflows/build.yml

Line 83 in bc1a5b2

echo ::set-output name=version::$BRANCH

for branches, line 77 is for tags. So feel free to add your bash ##*/ in there 😉 (or not up to you!)

[fredericrous]

I integrated the changes, I think we're good. thanks for having merged the / PR. I used to agree with you but changed my mind mainly because the / is supported in gitkraken (and I think in Git Extension but I never used this one and I'm on mac). Plus the / pattern is ok if we agree on putting one slash and no more

[qdm12]

Nice looking good! Just 3 tiny suggestions below

Also you may have to git rebase master your branch so that the readme has lfs (and also the CI gets fixed) 😉

[qdm12]

Nice thanks for the changes! A few additional points

1. can you rebase or merge the readme from master so we can merge it please
2. If you don't mind, can you sneak in the / fix you had to the verify job for the publish job as well? If it's too complicated, then we can skip it.

Thanks!!