Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match configured host for LuaDNS instead of first A/AAAA record #249

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Match configured host for LuaDNS instead of first A/AAAA record #249

merged 3 commits into from
Oct 6, 2021

Conversation

lymanepp
Copy link
Contributor

@lymanepp lymanepp commented Oct 1, 2021

I don't have an easy way to test this, but the change was loosely lifted from the dreamhost provider

Copy link
Owner

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should work 👍

If you don't mind, before merging it, have a go using this command to build the image (you need git installed):

docker build -t qmcgaw/ddns-updater https://github.com/lymanepp/ddns-updater.git#luadns-host

It should build relatively quickly too. And then you can use it as you did, since it's also named qmcgaw/ddns-updater.

@qdm12 qdm12 added 🐛 bug and removed 🐛 bug labels Oct 2, 2021
@lymanepp
Copy link
Contributor Author

lymanepp commented Oct 3, 2021

I'm a newbie when it comes to Docker, but I was finally able to get it working. Good thing too, because there was a bug. All fixed and tested now.

@qdm12 qdm12 merged commit ea215de into qdm12:master Oct 6, 2021
@lymanepp lymanepp deleted the luadns-host branch January 29, 2022 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants