Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHCR login and tag #259

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Add GHCR login and tag #259

merged 1 commit into from
Nov 17, 2021

Conversation

adamus1red
Copy link
Contributor

@adamus1red adamus1red commented Nov 6, 2021

Publish containers to the Github Container Repo at the same time as docker hub

Copy link
Owner

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯 !

Do you mind documenting in the Readme please? You can just add there is a mirror to the Docker Hub image in a one-liner, that should do 👍

@fredericrous
Copy link
Collaborator

just an honest question: why would you want to publish the image on 2 different spots? what advantage does it bring in your experience?

@qdm12
Copy link
Owner

qdm12 commented Nov 9, 2021

@fredericrous I guess as a backup, if Docker Hub goes down (it does, although rarely); Also Docker Hub has rate limiting (not a problem personally), but it can be problematic if you update your images automatically and have multiple updates e.g. the same day.

@adamus1red
Copy link
Contributor Author

@qdm12 that should be the README updated.

@qdm12 qdm12 merged commit 5b657df into qdm12:master Nov 17, 2021
@qdm12
Copy link
Owner

qdm12 commented Nov 17, 2021

Awesome, thanks it's merged!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants