-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DDNSS provider specific IPv6 update flow #270
Conversation
Fixed the sending of ipv6 information to ddnss provider
Thanks! Although checking https://ddnss.de/info.php and then pressing on "External IP" still shows the ip6 parameter. Can you perhaps confirm with them their documentation is wrong? |
@qdm12 Oh wow i did not see that. I ll check what i can do 😄 |
I sent them a description of the issue and request to clarify/fix the documentation via their contact form. I ll give feedback once they respond. |
Just a quick update. I got a response but it was not really helpful. But it triggered another test on my end and i found out that the I sent them another message if the |
Hey there any update? Should we just merge it as it is? |
Hey there any update? Thanks!! |
- Discussed on #270 - Original fix proposed by @quantum-byte
cd37ab1 should address this problem you have: it adds a boolean setting I tried force pushing to your fork but I got denied permission unfortunately, so I pushed it myself (mentioning you in the commit) to the master branch. |
Oh actually the forced push worked, sorry I don't know why my terminal was erroring although it succeeded. Anyway, let's consider this fixed 👍 (even if ddnss.de fixes it on their end) |
Hi @qdm12, sorry for the late reply and thanks for actually implementing a fix. It works and complies to their specification, even though its not specified anywhere. From the responses i got, they will also not change it ... |
Awesome thanks for letting me know. Also thanks for contributing, it's always appreciated! 👍 |
Fixed sending of specific ipv6 information to DDNSS provider.
The DDNSS provider only has one keyword (
ip
) for specifying the new ip (see documentation.Currently when an ipv6 ip would be provided the
ip6
keyword is filled. This leads to the behaviour that DDNSS picks the ip to fill since theip
keyword is missing. This is not expected behaviour ifuseProviderIP=false
.I tested it with my own account/setup. Feel free to validate with something like the following:
curl -i "https://www.ddnss.de/upd.php?key=<APIKEY>&host=<HOSTNAME>&ip=<IPV6>"