Add support for Dynu.com #285

msxdan · 2021-12-31T22:44:31Z

Added support for dynu. I could only test IPv4 as my ISP doesn't provide me an IPv6 but I added the right param to the query so it should work as good as IPv4 does.

Closes #222, #237, #263, #269

qdm12

Nice, thanks for the contribution!!! Especially on new year, impressive 🎉 !

Just a few nit-picking comments

internal/settings/providers/dynu/provider.go

qdm12 · 2022-01-03T09:37:27Z

internal/settings/providers/dynu/provider.go

+	case len(p.password) == 0:
+		return errors.ErrEmptyPassword
+	case p.host == "*":
+		return errors.ErrHostWildcard


Wildcards are not supported then right? Are custom hosts (i.e. a.example.com) supported?

If I use @ or * it updates all DDNS IPs for my domains on Dynu, * doesn't update subdomains of a concrete domain, so *.domain.com updates domain.com but not subdomain.domain.com

There's an alias (subdomain) parameter that could be used to update a concrete subdomain, to update a bunch of domains and subdomains in one call there's an optional parameter called location which could be used if configured in Dynu, would be similar to * but you have to set your domains and subdomains to a group in dynu.

I'm adding more features to support all these parameters, I'll update the pull as soon as I finish.

If I use @ or * it updates all DDNS IPs for my domains on Dynu, * doesn't update subdomains of a concrete domain, so *.domain.com updates domain.com but not subdomain.domain.com

I'm a bit confused here.
Correct me if I'm wrong:

@ for domain.com updates only domain.com but not `sub.domain.com

* for domain.com updates domain.com, domain2.com but not sub.domain.com

Well, @ does nothing really, if you don't set the hostname or if it's not a valid hostname for your user it will update all records for your domains that don't have a group assigned.

* doesn't acts like a wildcard, you can use it in the hostname but it will update only the domain.com and not sub.domain.com

internal/settings/providers/dynu/provider.go

msxdan · 2022-01-05T23:40:00Z

I finally added support for most options on Dynu, feel free to review and give any advices about code

Example usage: (Comments are for reference)

{
    "settings": [
        { // Subdomain update [any.host.dynu.net]
            "provider": "dynu",
            "domain": "dynu.net",
            "host": "host",
            "alias": "any",
            "username" : "user",
            "password": "63a9f0ea7bb98050796b649e85481845",
            "ip_version": "ipv4",
            "provider_ip": true
        },
        { // Subdomain update [www.host.dynu.net]
            "provider": "dynu",
            "domain": "dynu.net",
            "host": "host",
            "alias": "www",
            "username" : "user",
            "password": "63a9f0ea7bb98050796b649e85481845",
            "ip_version": "ipv4",
            "provider_ip": true
        },
        { // domain update [host.dynu.net]
            "provider": "dynu",
            "domain": "dynu.net",
            "host": "host",
            "alias": "",
            "username" : "user",
            "password": "63a9f0ea7bb98050796b649e85481845",
            "ip_version": "ipv4",
            "provider_ip": true
        },
        { // Group update [host.dynu.net | group=work]
            "provider": "dynu",
            "domain": "dynu.net",
            "host": "host",
            "alias": "",
            "location": "work",
            "username" : "user",
            "password": "63a9f0ea7bb98050796b649e85481845",
            "ip_version": "ipv4",
            "provider_ip": true
        },
        { // Update all domains you have in dynu that doesn't belongs to any group
            "provider": "dynu",
            "domain": "host.dynu.net",
            "host": "@",
            "username" : "user",
            "password": "63a9f0ea7bb98050796b649e85481845",
            "ip_version": "ipv4",
            "provider_ip": true
        }
    ]
}

internal/settings/providers/dynu/provider.go

qdm12 · 2022-01-06T08:06:36Z

internal/settings/providers/dynu/provider.go

+	case len(p.password) == 0:
+		return errors.ErrEmptyPassword
+	case p.host == "*":
+		return errors.ErrHostWildcard


If I use @ or * it updates all DDNS IPs for my domains on Dynu, * doesn't update subdomains of a concrete domain, so *.domain.com updates domain.com but not subdomain.domain.com

I'm a bit confused here.
Correct me if I'm wrong:

@ for domain.com updates only domain.com but not `sub.domain.com

* for domain.com updates domain.com, domain2.com but not sub.domain.com

msxdan · 2022-01-06T15:05:28Z

I removed the mess with extra params and simplified the usage, adding only an extra parameter for the group.

{
    "settings": [
        {
            "provider": "dynu",
            "domain": "dom.dynu.net",
            "host": "@",
            "username" : "user",
            "password": "<md5hash>",
            "ip_version": "ipv4",
            "provider_ip": false
        },
        {
            "provider": "dynu",
            "domain": "dom.dynu.net",
            "host": "www", // Subdomain
            "username" : "user",
            "password": "<md5hash>",
            "ip_version": "ipv4",
            "provider_ip": false
        },
        {
            "provider": "dynu",
            "domain": "dom.dynu.net",
            "host": "any", // Subdomain
            "username" : "user",
            "password": "<md5hash>",
            "ip_version": "ipv4",
            "provider_ip": false
        },
        {
            "provider": "dynu",
            "domain": "dom2.dynu.net",
            "host": "sub",
            "group": "work", // It will check the subdomain IP and update the group
            "username" : "user",
            "password": "<md5hash>",
            "ip_version": "ipv4",
            "provider_ip": false
        }
    ]
}

msxdan · 2022-01-20T22:49:01Z

Any news about these changes? I'm currently using it and it's working fine, we could merge it into master if you agree

qdm12

Sorry for the delay this got lost in my emails 😢
Just a few comments and let's merge this ASAP 😉
Thanks again for your work!

internal/settings/providers/dynu/provider.go

C-SELLERS · 2022-01-30T21:37:23Z

Just built and am using an image of this branch for Dynu as well, everything seems to working fine. Thanks guys 😁

msxdan · 2022-02-05T14:44:22Z

Done!

qdm12 · 2022-02-05T17:12:21Z

Awesome thanks for your work and dedication @msxdan

msxdan added 3 commits December 31, 2021 23:04

Feat: add support for dynu.com

fdf0985

Doc: add dynu documentation

20331cd

Fix: golangci-lint missing space on comment

dcea4f0

qdm12 approved these changes Jan 3, 2022

View reviewed changes

msxdan added 3 commits January 6, 2022 00:05

feat(dynu): add full support

042cd3f

docs: update docs for dynu

c98b178

fix(dynu): output right provider string with alias

098c368

msxdan requested a review from qdm12 January 5, 2022 23:40

qdm12 reviewed Jan 6, 2022

View reviewed changes

msxdan added 2 commits January 6, 2022 15:59

feat(dynu): removed mess and made it user friendly

0fdcff8

docs(dynu): updated docs

8996d32

msxdan requested a review from qdm12 January 6, 2022 15:05

qdm12 reviewed Jan 21, 2022

View reviewed changes

chore(dynu): allow empty host

8233126

qdm12 merged commit 5b426af into qdm12:master Feb 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Dynu.com #285

Add support for Dynu.com #285

msxdan commented Dec 31, 2021 •

edited

Loading

qdm12 left a comment

qdm12 Jan 3, 2022

msxdan Jan 3, 2022

qdm12 Jan 6, 2022

msxdan Jan 6, 2022

msxdan commented Jan 5, 2022

qdm12 Jan 6, 2022

msxdan commented Jan 6, 2022 •

edited

Loading

msxdan commented Jan 20, 2022

qdm12 left a comment

C-SELLERS commented Jan 30, 2022

msxdan commented Feb 5, 2022

qdm12 commented Feb 5, 2022

Add support for Dynu.com #285

Add support for Dynu.com #285

Conversation

msxdan commented Dec 31, 2021 • edited Loading

qdm12 left a comment

Choose a reason for hiding this comment

qdm12 Jan 3, 2022

Choose a reason for hiding this comment

msxdan Jan 3, 2022

Choose a reason for hiding this comment

qdm12 Jan 6, 2022

Choose a reason for hiding this comment

msxdan Jan 6, 2022

Choose a reason for hiding this comment

msxdan commented Jan 5, 2022

qdm12 Jan 6, 2022

Choose a reason for hiding this comment

msxdan commented Jan 6, 2022 • edited Loading

msxdan commented Jan 20, 2022

qdm12 left a comment

Choose a reason for hiding this comment

C-SELLERS commented Jan 30, 2022

msxdan commented Feb 5, 2022

qdm12 commented Feb 5, 2022

msxdan commented Dec 31, 2021 •

edited

Loading

msxdan commented Jan 6, 2022 •

edited

Loading