add a provider for google cloud dns #337
Conversation
| dnsClient, err := clouddns.NewService(ctx) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| record, err := p.getRecord(dnsClient, recordType) | ||
| if err != nil && err != errors.ErrNotFound { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
I know this works fine, but I'm fighting hard to have the least dependency as possible.
Can these few calls be made without the sdk package?
Otherwise I'll look into it, feel free to let me know.
There was a problem hiding this comment.
I can see, that the old code dnsClient, err := clouddns.NewService(ctx)
changed to clouddns.NewService(ctx, option.WithHTTPClient(client), option.WithCredentialsJSON(p.credentials))
I can't tell who made this change, but i can't authenticate properly when option.WithHTTPClient(client) is active.
I also searched for the documentation regarding WithHTTPClient option, but could not manage to find anything describing the difference. The official docs state, this is the way to properly authenticate: https://github.com/googleapis/google-cloud-go#authorization
But they don't mention the HTTP client option.
When I remove the WithHTTPClient option authorization is fully working, otherwise I receive this error:
ERROR getting record resource set: googleapi: Error 401: Request is missing required authentication credential. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project.
I am happy to provide a PR that just removes the usage of the client, what do you think?
closes #336