Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Support for inwx #379

Merged
merged 2 commits into from
Dec 7, 2022
Merged

added Support for inwx #379

merged 2 commits into from
Dec 7, 2022

Conversation

Sipnol
Copy link
Contributor

@Sipnol Sipnol commented Oct 17, 2022

im new to GO so if i missed smth let me know

@Sipnol
Copy link
Contributor Author

Sipnol commented Nov 17, 2022

so is this still actively mantained?

Copy link
Owner

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you so much for the contribution!

Just got some minor code style comments (mostly due to my own not-so-good code that got copied over), but it's looking very good congrats 👍

Sorry for being so late reviewing it, I've been moving (continents) whilst doing a full time job and taking care of our new puppy, so some emails got lost in the process 😄

internal/settings/providers/inwx/provider.go Outdated Show resolved Hide resolved
internal/settings/providers/inwx/provider.go Outdated Show resolved Hide resolved
internal/settings/providers/inwx/provider.go Outdated Show resolved Hide resolved
internal/settings/providers/inwx/provider.go Outdated Show resolved Hide resolved
internal/settings/providers/inwx/provider.go Outdated Show resolved Hide resolved
internal/settings/providers/inwx/provider.go Outdated Show resolved Hide resolved
@qdm12 qdm12 merged commit bd4b870 into qdm12:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants