Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for easydns #480

Merged
merged 6 commits into from
Jun 12, 2023
Merged

feat: add support for easydns #480

merged 6 commits into from
Jun 12, 2023

Conversation

charlydaily
Copy link
Contributor

@charlydaily charlydaily commented Jun 6, 2023 •
edited by qdm12

qdm12
qdm12 requested changes Jun 7, 2023
View reviewed changes
Copy link
Owner

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add docs/easydns.md documenting how to use it (start copy pasting for example docs/noip.md)
  • Please add easydns to the list of providers in the README.md
  • Please register the new provider in

    ddns-updater/internal/settings/settings.go

    Line 68 in 43d405c

    switch provider {
    (internal/settings/settings.go)

@qdm12 qdm12 force-pushed the easydns branch 2 times, most recently from 834999e to 5f34a7f Compare June 12, 2023 14:13
qdm12
qdm12 approved these changes Jun 12, 2023
View reviewed changes
docs/easydns.md Show resolved Hide resolved
docs/easydns.md Show resolved Hide resolved
@qdm12 qdm12 merged commit 6a9ba7e into qdm12:master Jun 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qdm12 qdm12 qdm12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: add EasyDNS
2 participants
@charlydaily @qdm12