Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): add suport for deSEC #496

Merged
merged 8 commits into from
Jun 30, 2023
Merged

feat(provider): add suport for deSEC #496

merged 8 commits into from
Jun 30, 2023

Conversation

biochron
Copy link
Contributor

Fixes #475

Copy link
Owner

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks 💯
Just a few tiny comments to address before merging

docs/desec.md Outdated Show resolved Hide resolved
internal/provider/providers/desec/provider.go Outdated Show resolved Hide resolved
internal/provider/providers/desec/provider.go Show resolved Hide resolved
internal/provider/providers/desec/provider.go Outdated Show resolved Hide resolved
biochron and others added 3 commits June 26, 2023 15:13
Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
docs/desec.md Outdated Show resolved Hide resolved
internal/provider/providers/desec/provider.go Show resolved Hide resolved
biochron and others added 2 commits June 27, 2023 19:57
Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
docs/desec.md Outdated Show resolved Hide resolved
@qdm12 qdm12 merged commit 7b3b660 into qdm12:master Jun 30, 2023
5 checks passed
@qdm12
Copy link
Owner

qdm12 commented Jun 30, 2023

Merged, thanks 🎖️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: support dedyn
2 participants