Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(surfshark): update API endpoint and servers data #1560

Merged
merged 5 commits into from
Jul 21, 2023
Merged

feat(surfshark): update API endpoint and servers data #1560

merged 5 commits into from
Jul 21, 2023

Conversation

eiqnepm
Copy link
Contributor

@eiqnepm eiqnepm commented May 8, 2023

I noticed that the static servers were missing for WireGuard, I'm not sure if any other locations are missing static servers, this is only for London

@qdm12
Copy link
Owner

qdm12 commented May 10, 2023

We need the update process to be automated, so please update the update code in https://github.com/qdm12/gluetun/tree/master/internal/provider/surfshark/updater to get additional servers data. Alternatively, how did you get the new data? It also seems you removed 38K lines from servers.json, not sure why 🤔

@eiqnepm
Copy link
Contributor Author

eiqnepm commented May 10, 2023

how did you get the new data?

Surfshark has an API to get lists of their servers and their connection info at https://api.surfshark.com/v4/server/clusters, it has the following paths, generic, double, static, and obfuscated.

you removed 38K lines from servers.json, not sure why 🤔

Must have been automatically formatted to be more readable because I use Prettier, the removals will just be whitespace.

@eiqnepm eiqnepm closed this May 10, 2023
@eiqnepm eiqnepm reopened this May 10, 2023
@eiqnepm
Copy link
Contributor Author

eiqnepm commented May 11, 2023

I have reverted the edit to the JSON file and instead updated the code to include the missing WireGuard servers.

@qdm12
Copy link
Owner

qdm12 commented Jul 21, 2023

Awesome, I rebased your branch, did a few very minor changes and updated the servers.json using go run ./cmd/gluetun/main.go update -maintainer -providers "surfshark". I'll merge this 😉 Great job 💯

@qdm12 qdm12 changed the title Add Surfshark London static server for WireGuard feat(surfshark): update API endpoint and servers data Jul 21, 2023
@qdm12 qdm12 merged commit c5cc240 into qdm12:master Jul 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants