feat: add PORT_FORWARD_ONLY env to filter for servers with port forwarding #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
previously approved these changes
Jan 29, 2024
qdm12
previously approved these changes
Feb 21, 2024
|
There is a test failing 😢 |
komachi
force-pushed
the
port-forward-only
branch
from
ffdeb24
to
1ff9824
Compare
|
Sorry, fixed. |
komachi
force-pushed
the
port-forward-only
branch
from
1ff9824
to
9a3b842
Compare
qdm12
approved these changes
Mar 18, 2024
qdm12
force-pushed
the
port-forward-only
branch
from
9a3b842
to
af7d067
Compare
|
Thanks! 💯 Feel free to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was in TODO per comment in code, so I took freedom to implement this. It adds another env PORT_FORWARD_ONLY which will filter for servers supporting port forwarding. This works only for PIA, I presume, so I locked this to only PIA support. Cases like #2048 could be mitigated with this PR merged and this settings on.