Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Universal Support #15

Closed
mclouvem opened this issue Sep 16, 2016 · 10 comments
Closed

Feature: Universal Support #15

mclouvem opened this issue Sep 16, 2016 · 10 comments

Comments

@mclouvem
Copy link

Hi @qdouble,

Now with Angular 2.0.0 and Angular Universal 2.0.0 is out, is there any plan to add it to this kit?

Or could you provide some guidance how to make it?

@qdouble
Copy link
Owner

qdouble commented Sep 16, 2016

@mclouvem I will probably add it soon, I was just waiting for it to be stable. I will test it out today.

@qdouble
Copy link
Owner

qdouble commented Sep 16, 2016

@mclouvem I started the setup for it, but I hit a bump in the road for now.... Material Design 2 doesn't currently work with Universal, so that support needs to be added for me add Universal to this repo.

You can track the issue here: angular/components#308

@mclouvem
Copy link
Author

hey @qdouble did you read that Patrick from AngularUniversal announced that AngularUniversal is now supporting Material2?

@qdouble
Copy link
Owner

qdouble commented Sep 18, 2016

@mclouvem yes, it's more or less a webpack hack though rather than native support. I have it running, but seems to be some issues with md-input. I'll release initial implementation of it tonight though, I already have it up and running, just making tweaks and stuff.

@qdouble qdouble changed the title Question: Plan to add universal support Feature: Universal Support Sep 18, 2016
@qdouble
Copy link
Owner

qdouble commented Sep 18, 2016

@mclouvem I just added the basic setup for Universal. Currently, there is still an issue with md-input so I'm not using it in the repo right now. I still need to add support for AOT mode while using Universal and also look into using preboot and stuff like that so values that are entered before full load are saved. It's a WIP but the basic framework is there and I've tried to lay it the project in a way where I can update it and you could easily just insert your app folder to the updated seed.

@mclouvem
Copy link
Author

@qdouble that's great! Thank you it was quick... I'll update my project today.
Could you explain more about what's wrong with md-input?

@qdouble
Copy link
Owner

qdouble commented Sep 18, 2016

It causes universal to have a circular JSON error. Should work smooth once
material officially supports Universal though.
On Sun, Sep 18, 2016 at 2:38 AM mclouvem notifications@github.com wrote:

@qdouble https://github.com/qdouble that's great! Thank you it was
quick... I'll update my project today.
Could you explain more about what's wrong with md-input?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ7seHJBwekweIFcDYOenj0Z6IKPMJStks5qrQaRgaJpZM4J_Mfk
.

@qdouble
Copy link
Owner

qdouble commented Sep 19, 2016

@mclouvem closing this as preboot runs fine, so Universal itself is working good. I'll ping you whenever the md-input thing is sorted out.

@qdouble qdouble closed this as completed Sep 19, 2016
@qdouble
Copy link
Owner

qdouble commented Sep 19, 2016

@mclouvem was talking with going back and forward with patrick in Slack and got him to fix the md-input bug in the latest update, so it's working fine now 😄

@mclouvem
Copy link
Author

Thanks again @qdouble. You're working hard on this starter...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants