Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urllib3 = "^1.26.14" are there plans to migrate to urllib3 ~2.0 #374

Closed
domik82 opened this issue Nov 12, 2023 · 5 comments
Closed

urllib3 = "^1.26.14" are there plans to migrate to urllib3 ~2.0 #374

domik82 opened this issue Nov 12, 2023 · 5 comments

Comments

@domik82
Copy link

domik82 commented Nov 12, 2023

According to
https://github.com/qdrant/qdrant-client/blob/d6100614fd2b8413781763d57013f0ee376741e1/pyproject.toml#L27C1-L27C21

This client is only allowed to use urllib3 = "^1.26.14"
Without migration to 2.0/2.1 it might hold back some other projects due to diamond dependency. Are there plans to migrate?

@stefanknegt
Copy link

Also interested in this

@sfitts
Copy link

sfitts commented Jan 3, 2024

This has us blocked at the 0.11.9 version of this library since we need urllib>=2.0.x for another library. Of course, being stuck there is now blocking an update to langchain. So, it's a bit of a mess.

@joein
Copy link
Member

joein commented Jan 5, 2024

Hello, thanks for pointing it out!

We are considering unfreezing this dependency, but first we would need to solve this #310

@joein
Copy link
Member

joein commented Jan 8, 2024

#418

@joein
Copy link
Member

joein commented Jan 8, 2024

Should be available with the next release

Closing for now, feel free to re-open if won't work in the next release

@joein joein closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants