Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clippy and linter to pre-commit hook #68

Closed
generall opened this issue Jul 14, 2021 · 2 comments
Closed

Add clippy and linter to pre-commit hook #68

generall opened this issue Jul 14, 2021 · 2 comments
Labels
chore Nice to have improvement enhancement New feature or request

Comments

@generall
Copy link
Member

Is your feature request related to a problem? Please describe.
Right now developers might forget to use code linters and static analyzers before submitting changes and only get the feedback after CI runs, which might be too slow.

Describe the solution you'd like
Add pre-commit hook which should be executed before each commit to rust code. This hook should automatically check and (optionally) automatically fix issues related to code formatting.

Describe alternatives you've considered
Do we want to force auto-fix of formatting?

Additional context
No

@generall generall added enhancement New feature or request chore Nice to have improvement labels Jul 14, 2021
@agourlay
Copy link
Member

Started in #68

Do we still want to add clippy to the pre-commit hool?

@generall
Copy link
Member Author

Do we still want to add clippy to the pre-commit hool?

I didn't find a way to quickly cancel the check if nothing related to clippy is changed. So enabling clippy by default on every commit might be annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Nice to have improvement enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants