List aliases API (rest & gRPC) #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agourlay
force-pushed
the
list-aliases
branch
from
99e4c0b
to
a4f0fec
Compare
agourlay
commented
Jan 17, 2023
src/actix/api/collections_api.rs
Outdated
| @@ -151,6 +158,7 @@ async fn update_collection_cluster( | |||
| // Configure services | |||
| pub fn config_collections_api(cfg: &mut web::ServiceConfig) { | |||
| cfg.service(get_collections) | |||
| .service(get_aliases) // higher priority than /collections/{name} | |||
There was a problem hiding this comment.
There is a subtle issue here, the get_aliases needs must have a higher priority than get_collection.
GET collections/aliases vs GET collections/{name} are conflicting with each other.
Maybe we should forbid the creation of collections name aliases?
There was a problem hiding this comment.
WDYT about GET /aliases for all aliases and GET /collections/<name>/aliases for aliases associated with specified colelction?
Similar to /snapshots
There was a problem hiding this comment.
Thanks for the suggestion 👍
Done in 4b6ef78
generall
approved these changes
Jan 18, 2023
generall
pushed a commit
that referenced
this pull request
Feb 6, 2023
* List aliases API (rest & gRPC) * rework api to avoid conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new API for listing existing collections aliases.
This change requires to update the clients to expose the new feature.