Implemented response resolver (#1370, #1381) #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generall
reviewed
Jan 20, 2023
|
Just realized there's probably a bug in I'll figure how to fix it soon-ish. ack @generall |
|
This was tedious to implement and annoying to test. @generall, can you make a final review, please? |
generall
requested changes
Jan 24, 2023
ffuugoo
commented
Jan 24, 2023
generall
approved these changes
Jan 24, 2023
ffuugoo
changed the title
`clippy --tests` :/
- from public to private - from general logic to implementation detail
ffuugoo
force-pushed
the
1370-read-consistency-response-resolver
branch
from
9881a70
to
b082d52
Compare
generall
added a commit
that referenced
this pull request
Feb 6, 2023
- Implement `Resolve` trait that "merges" multiple `retrieve`/`scroll_by`/`search` responses into a single response, to ensure it's consistent across multiple nodes in the cluster - Implement tests for the `Resolve` trait implementation - Add a few additional derives required for the `Resolve` trait implementation Co-authored-by: Andrey Vasnetsov <andrey@vasnetsov.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented logic that "merge" multiple
Vec<Record>/Vec<ScoredPoint>responses into a single response.The merged response only retains items that are present either in majority (more than half) or all of the original responses.
TODO:
execute_read_operation