Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge remaining runtimes #1398

Merged
merged 4 commits into from
Jan 25, 2023
Merged

Merge remaining runtimes #1398

merged 4 commits into from
Jan 25, 2023

Conversation

agourlay
Copy link
Member

@agourlay agourlay commented Jan 24, 2023

THis PR merges the remaining Tokio runtimes into a single global one named general.

The remaining runtimes were:

  • tonic
  • tonic-internal
  • toc
  • consensus-rt

threads

@agourlay agourlay marked this pull request as ready for review January 24, 2023 14:47
@agourlay agourlay linked an issue Jan 24, 2023 that may be closed by this pull request
Base automatically changed from share-optimizer-runtime to dev January 25, 2023 07:05
@agourlay agourlay force-pushed the merge-runtimes branch 2 times, most recently from b26e95d to 4982fd4 Compare January 25, 2023 08:30
@generall generall merged commit 6a14e52 into dev Jan 25, 2023
@agourlay agourlay deleted the merge-runtimes branch January 25, 2023 12:46
generall pushed a commit that referenced this pull request Feb 6, 2023
* Collections share a single optimizer runtime

* Merge remaining runtimes

* complete optimizer runtime renaming

* Give general_runtime ownership to toc to avoid shutdown issues
@generall generall mentioned this pull request Apr 19, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce number of runtimes
2 participants