Enable on disk payload option by default #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agourlay
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
I agree with this change from a user perspective.
In my opinion it is less surprising for a user if the payloads are located by default on disk.
This makes the system handle small and large payloads by default.
For advanced users, the configuration knob is available to change this explicitly if necessary.
generall
approved these changes
Jan 31, 2023
ffuugoo
approved these changes
Jan 31, 2023
IvanPleshkov
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payload often consumes a lot of RAM, thus it might be reasonable to store it on disk by default.