Implement Deserialize for ExtendedPointId to improve error reporting #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generall
approved these changes
Jan 31, 2023
generall
pushed a commit
that referenced
this pull request
Feb 6, 2023
…1416) * Implement Deserialize for ExtendedPointId to improve error reporting * better error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are struggling errors due to malformed point ids when upserting points in batch fashion.
The error does not mention the problematic input.
Serde's untagged union is known for this issue.
I found the following post exposing an idea as a workaround when using only JSON https://users.rust-lang.org/t/serde-untagged-enum-ruins-precise-errors/54128