Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UUID as point id #265

Merged
merged 4 commits into from Jan 31, 2022
Merged

UUID as point id #265

merged 4 commits into from Jan 31, 2022

Conversation

generall
Copy link
Member

@generall generall commented Jan 29, 2022

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally using cargo fmt command prior to submission?
  3. Have you checked your code using cargo clippy command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@generall generall marked this pull request as draft January 29, 2022 16:19
@generall
Copy link
Member Author

#255

@generall generall marked this pull request as ready for review January 29, 2022 19:12
@generall generall changed the title [WIP] UUID as point id UUID as point id Jan 29, 2022
@generall
Copy link
Member Author

It might seems like a lot of changs, but actually it is mostly an additional .into() for each const point_id used in tests

@@ -139,34 +137,39 @@ impl Collection {
});
}

// Retrieve 1 extra point to determine proper `next_page_offset`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an unrelated issue existing in the main branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's due to the change, that we can not calculate the next ID anymore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it thanks 👍

@agourlay
Copy link
Member

All those into() are rather noisy but I do not see a better alternative.

@generall
Copy link
Member Author

All those into() are rather noisy but I do not see a better alternative.

same, there are no implicit conversion like in Scala. But it is only noisy in tests

@generall generall merged commit 65787f7 into master Jan 31, 2022
@generall generall deleted the 128-bit-id-255 branch January 31, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants