New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UUID as point id #265
UUID as point id #265
Conversation
It might seems like a lot of changs, but actually it is mostly an additional |
@@ -139,34 +137,39 @@ impl Collection { | |||
}); | |||
} | |||
|
|||
// Retrieve 1 extra point to determine proper `next_page_offset` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an unrelated issue existing in the main branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it's due to the change, that we can not calculate the next ID anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it thanks 👍
All those |
same, there are no implicit conversion like in Scala. But it is only noisy in tests |
All Submissions:
New Feature Submissions:
cargo fmt
command prior to submission?cargo clippy
command?Changes to Core Features: