-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split collection.rs
into sub-modules
#2762
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generall
approved these changes
Oct 5, 2023
14 tasks
generall
pushed a commit
that referenced
this pull request
Oct 6, 2023
* Rename `collection.rs` to `collection/mod.rs` * Extract `collection/collection_ops.rs` * Extract `collection/point_ops.rs` * Extract `collection/search.rs` * Extract `collection/shard_transfer.rs` * Extract `collection/snapshots.rs` * fixup! Extract `collection/collection_ops.rs` * Reorder items in `collection/mod.rs` (1/?) * Reorder items in `collection/mod.rs` (2/?) * Reorder items in `collection/mod.rs` (3/?) * Reorder items in `collection/mod.rs` (4/?) * Reorder items in `collection/mod.rs` (5/?) * Reorder items in `collection/mod.rs` (6/?) * Reorder items in `collection/mod.rs` (7/?) * Reorder items in `collection/mod.rs` (8/?) * Reorder items in `collection/collection_ops.rs` (1/2) * Reorder items in `collection/collection_ops.rs` (2/2) * Add explicit imports to `collection/collection_ops.rs` * Add explicit imports to `collection/point_ops.rs` * Reorder items in `collection/search.rs` (1/2) * Reorder items in `collection/search.rs` (2/2) * Add explicit imports to `collection/search.rs` * Reorder items in `collection/shard_transfer.rs` (1/3) * Reorder items in `collection/shard_transfer.rs` (2/3) * Reorder items in `collection/shard_transfer.rs` (3/3) * Add explicit imports to `collection/shard_transfer.rs` * Reorder items in `collection/snapshots.rs` (1/?) * Reorder items in `collection/snapshots.rs` (2/?) * Reorder items in `collection/snapshots.rs` (3/?) * Reorder items in `collection/snapshots.rs` (4/?) * Add explicit imports to `collection/snapshots.rs` * Optimize imports in `collection/mod.rs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
collection.rs
into:collection/mod.rs
is a bit less than 600 LOC, everything else is around 300 lines.This PR is structured the same way as #2761 (see its description for further details).
All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?Changes to Core Features: