Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split collection.rs into sub-modules #2762

Merged
merged 32 commits into from Oct 5, 2023
Merged

Split collection.rs into sub-modules #2762

merged 32 commits into from Oct 5, 2023

Conversation

ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented Oct 4, 2023

Refactor collection.rs into:

collection/
└── mod.rs
└── collection_ops.rs
└── point_ops.rs
└── search.rs
└── shard_transfer.rs
└── snapshots.rs

collection/mod.rs is a bit less than 600 LOC, everything else is around 300 lines.

This PR is structured the same way as #2761 (see its description for further details).

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

@generall generall merged commit e06bb4f into dev Oct 5, 2023
18 checks passed
@generall generall deleted the split-collection branch October 5, 2023 01:52
generall pushed a commit that referenced this pull request Oct 6, 2023
* Rename `collection.rs` to `collection/mod.rs`

* Extract `collection/collection_ops.rs`

* Extract `collection/point_ops.rs`

* Extract `collection/search.rs`

* Extract `collection/shard_transfer.rs`

* Extract `collection/snapshots.rs`

* fixup! Extract `collection/collection_ops.rs`

* Reorder items in `collection/mod.rs` (1/?)

* Reorder items in `collection/mod.rs` (2/?)

* Reorder items in `collection/mod.rs` (3/?)

* Reorder items in `collection/mod.rs` (4/?)

* Reorder items in `collection/mod.rs` (5/?)

* Reorder items in `collection/mod.rs` (6/?)

* Reorder items in `collection/mod.rs` (7/?)

* Reorder items in `collection/mod.rs` (8/?)

* Reorder items in `collection/collection_ops.rs` (1/2)

* Reorder items in `collection/collection_ops.rs` (2/2)

* Add explicit imports to `collection/collection_ops.rs`

* Add explicit imports to `collection/point_ops.rs`

* Reorder items in `collection/search.rs` (1/2)

* Reorder items in `collection/search.rs` (2/2)

* Add explicit imports to `collection/search.rs`

* Reorder items in `collection/shard_transfer.rs` (1/3)

* Reorder items in `collection/shard_transfer.rs` (2/3)

* Reorder items in `collection/shard_transfer.rs` (3/3)

* Add explicit imports to `collection/shard_transfer.rs`

* Reorder items in `collection/snapshots.rs` (1/?)

* Reorder items in `collection/snapshots.rs` (2/?)

* Reorder items in `collection/snapshots.rs` (3/?)

* Reorder items in `collection/snapshots.rs` (4/?)

* Add explicit imports to `collection/snapshots.rs`

* Optimize imports in `collection/mod.rs`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants