Make GeoPolygon interiors optional #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agourlay
commented
Oct 5, 2023
| @@ -1350,7 +1350,7 @@ pub struct GeoPolygon { | |||
| /// Interior lines (if present) bound holes within the surface | |||
| /// each GeoLineString must consist of a minimum of 4 points, and the first | |||
| /// and last points must be the same. | |||
| pub interiors: Vec<GeoLineString>, | |||
| pub interiors: Option<Vec<GeoLineString>>, | |||
There was a problem hiding this comment.
here is the important change.
Scrolling above you will find the shadow type which already had the optional field
#[derive(Deserialize)]
pub struct GeoPolygonShadow {
pub exterior: GeoLineString,
pub interiors: Option<Vec<GeoLineString>>,
}
generall
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2315 we made the
interiorsfield of geo polygons effectively optional by performing the validation in a shadow type.We have tests showing that it works fine but we forgot to propagate the change to the type which provided the JSON schema.
Issue discovered while updating the Python client qdrant/qdrant-client#325