fix missing indexing values on set-payload operation #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
timvisee
approved these changes
Dec 19, 2023
IvanPleshkov
approved these changes
Dec 19, 2023
generall
added a commit
that referenced
this pull request
Dec 19, 2023
* fix missing indexing values on set-payload operation * Update function documentation, use conventional warning * Don't deep match statements * test: Update of payload on already indexed payload should work (#3253) --------- Co-authored-by: timvisee <tim@visee.me> Co-authored-by: Kumar Shivendu <kshivendu1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened:
assignoperation was trying to upgrade index no matter is the value was actually present in the index or not. It was considering the non-present value asNone(which is incorrect)Why it broke only in 1.7.x?
assignwill not try to insert non-existing fields.Current changes are tested manually on the reproducible example, proper integration tests will be introduces in another PR by @KShivendu
Scenario to reproduce:
set_pyaloadwith the field, which is NOT index