Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to request recovery point for remote shard #3510

Merged
merged 6 commits into from
Feb 9, 2024

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented Feb 1, 2024

Tracked in: #3477

This adds an gRPC (internal) interface to request the recovery point of a remote shard. It also adds a convenience function to the RemoteShard to easily access this.

It has a new RecoveryPoint type, similar to the ClockMap, to hold the clock states. Right now it just returns the last seen clock states as recovery point.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

@timvisee timvisee marked this pull request as ready for review February 8, 2024 16:55
@timvisee timvisee requested a review from ffuugoo February 8, 2024 16:55
@timvisee
Copy link
Member Author

timvisee commented Feb 8, 2024

image

It seems like our gRPC generator is having a stroke, moving a whole lot of things around.

@timvisee timvisee force-pushed the shard-recovery-point-endpoint branch from d99708e to 8efa9c3 Compare February 9, 2024 15:38
@timvisee timvisee merged commit 4c6b940 into dev Feb 9, 2024
17 checks passed
@timvisee timvisee deleted the shard-recovery-point-endpoint branch February 9, 2024 15:57
ffuugoo added a commit that referenced this pull request Feb 23, 2024
timvisee pushed a commit that referenced this pull request Feb 23, 2024
timvisee added a commit that referenced this pull request Mar 5, 2024
* Add initial gRPC call for requesting WAL recovery point for remote shard

* Add remote shard method to request WAL recovery point

* Add recovery point type in gRPC, use it in recovery point functions

* Add function to extend recovery point with missing clocks from clock map

* Add new gRPC type for recovery point clocks

* Remove atomic loading, because we use regular integers now
timvisee pushed a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants