-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint to request recovery point for remote shard #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100 tasks
timvisee
force-pushed
the
shard-recovery-point-endpoint
branch
from
February 8, 2024 15:57
d33fe07
to
7a15f5f
Compare
timvisee
commented
Feb 8, 2024
This was referenced Feb 8, 2024
14 tasks
timvisee
force-pushed
the
shard-recovery-point-endpoint
branch
from
February 9, 2024 15:38
d99708e
to
8efa9c3
Compare
generall
approved these changes
Feb 9, 2024
ffuugoo
added a commit
that referenced
this pull request
Feb 23, 2024
timvisee
added a commit
that referenced
this pull request
Mar 5, 2024
* Add initial gRPC call for requesting WAL recovery point for remote shard * Add remote shard method to request WAL recovery point * Add recovery point type in gRPC, use it in recovery point functions * Add function to extend recovery point with missing clocks from clock map * Add new gRPC type for recovery point clocks * Remove atomic loading, because we use regular integers now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in: #3477
This adds an gRPC (internal) interface to request the recovery point of a remote shard. It also adds a convenience function to the
RemoteShard
to easily access this.It has a new
RecoveryPoint
type, similar to theClockMap
, to hold the clock states. Right now it just returns the last seen clock states as recovery point.All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?