Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1/3 of #3637 (comment).
Roadmap/general idea: let the new and the old implementation coexist for a while. Introduce a new trait that both implementations will implement. Use the same set of unit tests for both implementations.
This PR adds a new trait
JsonPathInterface
and its implementationJsonPathString
which behaves exactly like the old implementation.All the code is updated to use the new interface. These are mostly mechanical changes in tests.
Additionally, this PR adds an empty stub implementation of
JsonPathV2
just to check that everything compiles if we replace the old implementation with the new one. It panics though.All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?Changes to Core Features: