Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of structs has a
Deserialize
derive despite we never deserialize them.It is inconvenient for the following reasons:
Deserialize
, a developer could search and review all the places in the code base where this specific value originates. If it'sDeserialize
, this means that data could be arbitrary. E.g., my histogram bucket merging code works fine for data being generated by my code, but it's not true for arbitrary data.impl Serialize
for some field since then we have to implement a customDeserialize
too.This PR drops unused
Deserialize
impls. Precisely, the following things removed:#[derive(Deserialize)]
, obviously.#[serde(default)]
for non-deserializable structs.#[derive(Validate)]
and#[validate]
in one place.All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?Changes to Core Features: