Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: use impl instead of dyn in vector storage #3690

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Chore: use impl instead of dyn in vector storage #3690

merged 1 commit into from
Feb 26, 2024

Conversation

coszio
Copy link
Contributor

@coszio coszio commented Feb 26, 2024

Since Rust 1.75, now we can use return-position impl Trait in traits, so we can now turn these return signatures into impl Iterator<...>s

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@coszio coszio merged commit af8e42b into dev Feb 26, 2024
17 checks passed
@coszio coszio deleted the use-impl-trait-in-vector-storage branch February 26, 2024 16:18
timvisee pushed a commit that referenced this pull request Mar 5, 2024
@coszio @timvisee
refactor: dyn -> impl in vector storage (#3690)
016a80c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agourlay agourlay agourlay approved these changes

@generall generall generall approved these changes

@timvisee timvisee Awaiting requested review from timvisee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coszio @agourlay @generall