Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to JsonPathV2 #3709

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Switch to JsonPathV2 #3709

merged 1 commit into from
Feb 29, 2024

Conversation

xzfc
Copy link
Contributor

@xzfc xzfc commented Feb 27, 2024

This PR switches the old JsonPathString with the new JsonPathV2.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@generall
Copy link
Member

Some tests are broken

Copy link
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Once the old implementation is gone, do we remove the V2 suffix?

@generall generall merged commit 8d8f834 into dev Feb 29, 2024
17 checks passed
@generall generall deleted the json-path-enable-v2 branch February 29, 2024 13:55
@xzfc xzfc mentioned this pull request Mar 4, 2024
9 tasks
timvisee pushed a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants