Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce that storage compatibility validates master data on dev #3717

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

agourlay
Copy link
Member

@agourlay agourlay commented Feb 28, 2024

So far our strategy for testing storage compatibility has been to refresh from time to time a set of archives containing data and snapshots and making sure that the current dev branch understand those.

This PR proposes to make the contract clearer by only pulling the archives from the master branch during tests.

This makes sure we have a stable point of reference.

@agourlay agourlay requested a review from coszio February 28, 2024 14:18
Copy link
Contributor

@coszio coszio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach

@agourlay agourlay merged commit fd442ac into dev Feb 28, 2024
17 checks passed
@agourlay agourlay deleted the storage-compat-dev-vs-master branch February 28, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants