Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrderBy: Allow integer in StartFrom #3726

Merged
merged 1 commit into from
Feb 29, 2024
Merged

OrderBy: Allow integer in StartFrom #3726

merged 1 commit into from
Feb 29, 2024

Conversation

coszio
Copy link
Contributor

@coszio coszio commented Feb 29, 2024

OrderBy tracked in #3521

Right now we accept integers in gRPC, but not in REST, this adds integer variant to the StartFrom interface

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@coszio coszio requested review from generall and xzfc February 29, 2024 14:12
@coszio coszio merged commit 5deee2a into dev Feb 29, 2024
17 checks passed
@coszio coszio deleted the integer-startfrom branch February 29, 2024 15:22
timvisee pushed a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants