Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

byte storage quantization fix and test #4063

Merged
merged 10 commits into from
Apr 19, 2024

Conversation

IvanPleshkov
Copy link
Contributor

@IvanPleshkov IvanPleshkov commented Apr 18, 2024

This PR adds quantization fixes for byte storage.

It supports all quantization types (SQ, BQ, and PQ) and adds unit tests covering PQ, SQ, PQ for Dot, Cosine metrics, and Nearest, Discovery, and Recommendation searches.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@IvanPleshkov IvanPleshkov force-pushed the byte-storage-quantization-fix-and-test branch from 9317787 to 36ba616 Compare April 18, 2024 17:57
@IvanPleshkov IvanPleshkov marked this pull request as ready for review April 18, 2024 19:08
@IvanPleshkov IvanPleshkov merged commit 528d759 into dev Apr 19, 2024
17 checks passed
@IvanPleshkov IvanPleshkov deleted the byte-storage-quantization-fix-and-test branch April 19, 2024 09:04
timvisee pushed a commit that referenced this pull request Apr 22, 2024
* byte storage quantization fix and test

* apply quantization_preprocess in quantization scorers

* exact true

* exact true

* calculate sames count

* wrong distance getter

* fix Manhattan distance getter

* less acc check

* fix build

* update acc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants