Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple ProxySegment::flush unit-test #4066

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented Apr 18, 2024

Add a unit test that checks that ProxySegment::flush works as expected. (Only tests sync = true flush currently.)

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Clarify comments explaining test cases
@timvisee timvisee merged commit b0c51ba into dev Apr 18, 2024
17 checks passed
@timvisee timvisee deleted the proxy-segment-flush-test branch April 18, 2024 14:30
timvisee pushed a commit that referenced this pull request Apr 22, 2024
* Add simple `ProxySegment::flush` unit-test

* fixup! Add simple `ProxySegment::flush` unit-test

Clarify comments explaining test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants