universal-query: Introduce new RawVector and VectorInput messages
#4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
coszio
force-pushed
the
universal-query-at-shards
branch
from
8509242
to
48df0f8
Compare
coszio
force-pushed
the
new-grpc-vector-message
branch
from
8de9f77
to
a0ddb6e
Compare
agourlay
reviewed
May 13, 2024
lib/api/src/grpc/proto/points.proto
Outdated
|
|
||
| message SparseVector { | ||
| repeated float data = 1; | ||
| optional SparseIndices indices = 2; |
coszio
force-pushed
the
new-grpc-vector-message
branch
from
a0ddb6e
to
9afc305
Compare
timvisee
approved these changes
May 14, 2024
agourlay
reviewed
May 14, 2024
| @@ -46,12 +46,36 @@ message SparseIndices { | |||
| repeated uint32 data = 1; | |||
| } | |||
|
|
|||
| // Legacy vector format, which determines the vector type by the configuration of its fields. | |||
There was a problem hiding this comment.
Legacy is always the system that pays the bills 👴
agourlay
approved these changes
May 14, 2024
ffuugoo
reviewed
May 15, 2024
There was a problem hiding this comment.
I've noticed that this PR pushed a binary into the repo. Is this something useful or an accident?
There was a problem hiding this comment.
Noticed, because I somehow also had this file on disk (but not checked into the repo) and git pull complained that this file will be overridden.
I guess, the fact that I already had this file on my machine, means it was produced (by build scripts?) at some point?
There was a problem hiding this comment.
Very good catch 👍
Let's nuke it, no idea where it comes from TBH
generall
pushed a commit
that referenced
this pull request
May 26, 2024
…#4209) * Introduce `RawVector` and `VectorInput` messages * gen grpc docs * remove extra `optional` * gen grpc docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #4198
Future-proofs the grpc query vector type to allow any shape of vector.
RawVector: Only bare vector shapesVectorInput: Can include point idsAll Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?