Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bool filter #421

Merged
merged 5 commits into from
Apr 3, 2022
Merged

Bool filter #421

merged 5 commits into from
Apr 3, 2022

Conversation

generall
Copy link
Member

All Submissions:

Implements #415

Refactors Match condition so that it does not require explicit type specification.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally using cargo fmt command prior to submission?
  3. Have you checked your code using cargo clippy command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@generall generall requested a review from agourlay March 30, 2022 09:45
Copy link
Member

@agourlay agourlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's your plan for removing the deprecated conditions?

@generall
Copy link
Member Author

What's your plan for removing the deprecated conditions?

Remove everything deprecated wit 1.0

@generall generall merged commit adc1f4a into master Apr 3, 2022
@generall generall deleted the bool-filter branch April 9, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants