Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to upstream hashring crate #4305

Merged
merged 1 commit into from
May 23, 2024
Merged

Switch back to upstream hashring crate #4305

merged 1 commit into from
May 23, 2024

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented May 23, 2024

Tracked in: #4213

jeromefroe/hashring-rs#25 got merged, so we can switch back to the upstream crate.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

@timvisee timvisee requested review from agourlay and ffuugoo May 23, 2024 07:34
@timvisee timvisee mentioned this pull request May 23, 2024
76 tasks
Copy link
Member

@agourlay agourlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job getting the change upstreamed 👍

@timvisee timvisee merged commit ffd5d1e into dev May 23, 2024
17 checks passed
@timvisee timvisee deleted the hashring-clone branch May 23, 2024 08:50
@timvisee timvisee added this to the v1.11: resharding milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants