Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReshardingOperations::CommitHashRing consensus message #4344

Merged
merged 1 commit into from
May 31, 2024

Conversation

ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented May 28, 2024

Tracked in #4213. Based on #4351.

This PR adds CommitHashRing consensus operation.

We might still redesign this (e.g., to use multiple hashring commit steps or something), but I'd expect most of the code in this PR to be reused anyway.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@ffuugoo ffuugoo mentioned this pull request May 28, 2024
63 tasks
@ffuugoo ffuugoo force-pushed the commit-hashring-consensus-message branch from b176f23 to b1481ef Compare May 29, 2024 13:08
@ffuugoo ffuugoo changed the base branch from dev to refactor-resharding-consensus-ops May 29, 2024 13:09
@ffuugoo ffuugoo force-pushed the commit-hashring-consensus-message branch from b1481ef to 1feeb03 Compare May 29, 2024 14:01
Base automatically changed from refactor-resharding-consensus-ops to dev May 29, 2024 14:58
@ffuugoo ffuugoo force-pushed the commit-hashring-consensus-message branch from 1feeb03 to efc6917 Compare May 30, 2024 08:47
@ffuugoo ffuugoo marked this pull request as ready for review May 30, 2024 08:48
lib/collection/src/hash_ring.rs Show resolved Hide resolved
@ffuugoo ffuugoo force-pushed the commit-hashring-consensus-message branch from efc6917 to 43fb84e Compare May 31, 2024 12:05
@ffuugoo ffuugoo merged commit abebd9d into dev May 31, 2024
17 checks passed
@ffuugoo ffuugoo deleted the commit-hashring-consensus-message branch May 31, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants