Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move resharding state into shard holder #4346

Merged
merged 3 commits into from
May 29, 2024

Conversation

timvisee
Copy link
Member

Tracked in: #4213

Move the resharding state from the collection struct into the shard holder. It now lives next to the shard transfers state.

I've also added a ReshardingKey which holds the peer ID, shard ID and resharding key because we commonly use these together. This matches with the shard transfer key.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

@timvisee timvisee requested a review from ffuugoo May 28, 2024 17:18
@timvisee timvisee mentioned this pull request May 28, 2024
63 tasks
Copy link
Contributor

@ffuugoo ffuugoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This makes much more sense, tbh. 😂

I have some minor comments, but I'll just fix them in my next PR.

@timvisee
Copy link
Member Author

I have some minor comments, but I'll just fix them in my next PR.

Sounds good!

@timvisee timvisee merged commit 4059b9e into dev May 29, 2024
17 checks passed
@timvisee timvisee deleted the move-resharding-state-into-shard-holder branch May 29, 2024 08:25
timvisee added a commit that referenced this pull request Jun 11, 2024
* Move resharding state into shard holder

* Update shard state inside shard holder

* Add resharding key struct to combine peer id, shard id and shard key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants