-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial stubs for resharding driver #4355
Conversation
917e4dc
to
8028b90
Compare
2c9886a
to
1e3274b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we don't neccessary need ReshardTask
. ReshardKey
+ ShardHolder::resharding_state
should be enough, but LGTM otherwise.
You might be right. My idea was that we might add additional information such as the desired shard distribution. I'll remove it for now. We can add it back later once we think it'll be useful again. |
* Initial stubs for resharding driver * Add basic steps in resharding driver * Link Notion document * Clean up start function * Describe difference between reshard key and task * Report resharding abort/finish to consensus * Add driver methods for remaining stages * Fix typo * Only start driver on the peer that is responsible for driving it * Remove ReshardTask, repurpose ReshardKey for that
Tracked in: #4213
Lay out the initial stubs for the logic driving the whole resharding process.
All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?