While resharding, respect configured shard transfer limits #4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvisee
force-pushed
the
resharding-migrate-local
branch
from
87b96df
to
85c062c
Compare
timvisee
force-pushed
the
resharding-migrate-respect-transfer-limits
branch
from
bde3bd6
to
50180e5
Compare
timvisee
force-pushed
the
resharding-migrate-respect-transfer-limits
branch
from
50180e5
to
262b202
Compare
timvisee
force-pushed
the
resharding-migrate-respect-transfer-limits
branch
from
262b202
to
40833fe
Compare
ffuugoo
approved these changes
Jun 20, 2024
timvisee
force-pushed
the
resharding-migrate-respect-transfer-limits
branch
from
40833fe
to
2f831a0
Compare
generall
pushed a commit
that referenced
this pull request
Jun 21, 2024
* Respect shard transfer limits in resharding point migrations * Simplify check for transfer limits, always allow local transfer * Respect shard transfer limits in resharding replication * Simplify shard transfer limit condition * Balance resharding by replicating to peers with lowest number of shards * Fix clippy warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in: #4213
Depends on: #4491
A user may configure incoming and outgoing shard transfer limits. This PR makes sure to respect these limits during resharding.
This also selects peers with the lowest number of shards while replicating to balance the shard distribution.
Tasks
devAll Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?