Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ergonomic Payload::deserialize (unoptimised version) #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TmLev
Copy link

@TmLev TmLev commented Jul 1, 2023

Continuation of #37, #37 (comment), and #37 (comment).

This PR enables library users to utilize the straightforward method Payload::deserialize(self) to deserialize a payload into any type T, as long as T implements serde::de::DeserializeOwned.

The current approach carries significant overhead as it initially serializes a payload into serde_json::Value and then deserializes it back.

One possible solution to mitigate this overhead could be the use of MapDeserializer (see more). However, this would require implementing IntoDeserializer for qdrant::Value, something which I was unable to accomplish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant