Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/202009 realtime updates 03 #145

Merged
merged 23 commits into from
Sep 27, 2020
Merged

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Sep 26, 2020

PR Details

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (framework not included)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #145 into master will increase coverage by 0.08%.
The diff coverage is 91.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   84.96%   85.04%   +0.08%     
==========================================
  Files         331      338       +7     
  Lines       11059    11181     +122     
  Branches     2018     2038      +20     
==========================================
+ Hits         9396     9509     +113     
- Misses       1111     1117       +6     
- Partials      552      555       +3     
Flag Coverage Δ
#all 85.04% <91.17%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
starsky/starsky/Startup.cs 0.00% <0.00%> (ø)
...tarsky/starsky/Controllers/MetaUpdateController.cs 55.10% <37.50%> (-1.42%) ⬇️
...foundation.realtime/Helpers/WebSocketConnection.cs 87.80% <87.80%> (ø)
...y.feature.metaupdate/Services/MetaUpdateService.cs 96.72% <100.00%> (+0.11%) ⬆️
.../starsky.foundation.platform/Helpers/PathHelper.cs 94.44% <100.00%> (ø)
.../starsky.foundation.platform/Models/AppSettings.cs 93.82% <100.00%> (+0.03%) ⬆️
...ntions/WebSocketConnectionsMiddlewareExtensions.cs 100.00% <100.00%> (ø)
...ealtime/Middleware/DisabledWebSocketsMiddleware.cs 100.00% <100.00%> (ø)
...ltime/Middleware/WebSocketConnectionsMiddleware.cs 100.00% <100.00%> (ø)
...tion.realtime/Model/WebSocketConnectionsOptions.cs 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e1c10...e8d462e. Read the comment docs.

@qdraw qdraw linked an issue Sep 27, 2020 that may be closed by this pull request
@qdraw qdraw linked an issue Sep 27, 2020 that may be closed by this pull request
@qdraw qdraw mentioned this pull request Sep 27, 2020
@qdraw qdraw merged commit 9853366 into master Sep 27, 2020
@qdraw qdraw deleted the feature/202009_realtime_updates_03 branch September 27, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

starksyimporter asterisk does not always pick first item View folders realtime
1 participant