Separate nodes and values #1770
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arate-nodes-and-values
turuslan
reviewed
Aug 29, 2023
Comment on lines
+21
to
+32
| class TrieNodeStorageBackend : public BufferStorage { | ||
| public: | ||
| ~TrieStorageBackend() override = default; | ||
| ~TrieNodeStorageBackend() override = default; | ||
| }; | ||
|
|
||
| /** | ||
| * Adapter for the trie value storage that allows to hide keyspace separation | ||
| * along with root hash storing logic from the trie db component | ||
| */ | ||
| class TrieValueStorageBackend : public BufferStorage { | ||
| public: | ||
| ~TrieValueStorageBackend() override = default; |
There was a problem hiding this comment.
Remove TrieNodeStorageBackend and TrieValueStorageBackend.
Use BufferStorage directly (or new simple interface TrieDb { get(Hash): Opt<Cow>; put(Hash, Cow); }, maybe get and put can accept bool for value/node).
If you want strong type for injection, then
don't inherit interface (because you can't use parent interface implementation struct IDb{}; struct Db:IDb{}; struct IDb2:IDb{}; IDb2 idb2 = new Db{};)
but wrapper struct (struct TrieDbNode { IDb _; }; struct TrieDbValue { IDb _; }; or struct TrieDb { IDb node, value; }),
or don't inject
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Benefits
Possible Drawbacks
Usage Examples or Tests
Alternate Designs