Feature/async-backing #1825
Merged
Feature/async-backing #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
move -> forward Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
…ncoding Signed-off-by: iceseer <iceseer@gmail.com> # Conflicts: # test/core/storage/trie_pruner/trie_pruner_test.cpp
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
This reverts commit 7ff93a3.
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
turuslan
reviewed
Feb 15, 2024
Comment on lines
716
to
722
| auto validation_protocol = [&]() -> std::shared_ptr<ProtocolBase> { | ||
| if (proto_version == network::CollationVersion::VStaging) { | ||
| return router_->getValidationProtocolVStaging(); | ||
| } else { | ||
| return router_->getValidationProtocol(); | ||
| } | ||
| }(); |
There was a problem hiding this comment.
Do you want to choose protocol supported by client,
or does runtime api return protocol version (e.g. async backing off/on)?
// may sort/reorder protocol list based on peer protocol list from "/identify"
host.newStream({"/validation/2", "/validation/1"}, [](r) {
if r.protocol == "/validation/1"
protocol_1.onOutgoingStream(r.stream)
if r.protocol == "/validation/2"
protocol_2.onOutgoingStream(r.stream)
})
kamilsa
reviewed
Feb 19, 2024
There was a problem hiding this comment.
Fix too many logs like:
24.02.19 04:50:00.089592 main_runner Warning ParachainProcessorImpl After `send_peer_messages_for_relay_parent` no parachain state on relay_parent. (relay_parent=0x9ff1…b8ac)
and
24.02.19 04:50:06.074950 main_runner Warning PeerManager Unable to create stream /e143f23803ac50e8f6f8e62695d1ce9e4e1d68aa36c1cd2cfd15340213f3423e/validation/1 with …uB1dLv: Stream: reset by remote peer
Signed-off-by: iceseer <iceseer@gmail.com>
turuslan
reviewed
Feb 19, 2024
zombienet/0001-parachains-smoke-test/0001-parachains-smoke-test.toml
Outdated
Show resolved
Hide resolved
xDimon
reviewed
Feb 19, 2024
core/network/impl/router_libp2p.cpp
Outdated
Comment on lines
94
to
95
| // app_state_manager_->takeControl(*collation_protocol_.get()); | ||
| // app_state_manager_->takeControl(*validation_protocol_.get()); |
| @@ -36,6 +36,18 @@ namespace kagome::math { | |||
| return res; | |||
| } | |||
|
|
|||
| template <typename T, typename E> | |||
| inline outcome::result<void> checked_sub(T &x, T y, E e) { | |||
| static_assert(std::numeric_limits<T>::is_integer | |||
There was a problem hiding this comment.
Suggested change
| static_assert(std::numeric_limits<T>::is_integer | |
| BOOST_STATIC_ASSERT(std::numeric_limits<T>::is_integer |
There was a problem hiding this comment.
BOOST_STATIC_ASSERT используется в 2 местах, а static_assert во всем остальном коде. Думаю логично переехать на static_assert
|
|
||
| protocol->request(peer_info, candidate_hash, std::forward<F>(callback)); | ||
| /// TODO(iceseer): do |
There was a problem hiding this comment.
Is TODO actual? Add more details if do

There was a problem hiding this comment.
https://imgur.com/9Rby94j.png 2-я строка
iceseer
force-pushed
the
feature/async_backing_net
branch
from
f3945ec
to
6f00882
Compare
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com> # Conflicts: # core/network/impl/peer_manager_impl.cpp # core/parachain/validator/impl/parachain_processor.cpp
iceseer
force-pushed
the
feature/async_backing_net
branch
3 times, most recently
from
4efbfdb
to
0c4c0b7
Compare
Signed-off-by: iceseer <iceseer@gmail.com>
iceseer
force-pushed
the
feature/async_backing_net
branch
from
0c4c0b7
to
36658b6
Compare
xDimon
reviewed
Feb 25, 2024
xDimon
approved these changes
Feb 26, 2024
Signed-off-by: iceseer <iceseer@gmail.com> # Conflicts: # core/network/impl/peer_manager_impl.cpp # core/parachain/validator/impl/parachain_processor.cpp
kamilsa
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Additionally