beefy fetch justification test #2091
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
igor-egorov
approved these changes
May 21, 2024
Harrm
reviewed
May 30, 2024
| #include "consensus/beefy/types.hpp" | ||
|
|
||
| namespace kagome::consensus::beefy { | ||
| class FetchJustification { |
| @@ -394,7 +397,17 @@ namespace kagome::network { | |||
| } | |||
| ++next_digest_; | |||
| } | |||
| if (sessions_.size() > 1 and sessions_.begin()->first <= beefy_finalized_) { | |||
There was a problem hiding this comment.
Why is only the first session checked?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Possible Drawbacks