Skip to content

Commit

Permalink
hw/block/nvme: fix set feature save field check
Browse files Browse the repository at this point in the history
Currently, no features are saveable, so the current check is not wrong,
but add a check against the feature capabilities to make sure this will
not regress if saveable features are added later.

Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
  • Loading branch information
Gollu Appalanaidu authored and birkelund committed Feb 8, 2021
1 parent 56990c7 commit 0065f42
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hw/block/nvme.c
Expand Up @@ -3324,7 +3324,7 @@ static uint16_t nvme_set_feature(NvmeCtrl *n, NvmeRequest *req)

trace_pci_nvme_setfeat(nvme_cid(req), nsid, fid, save, dw11);

if (save) {
if (save && !(nvme_feature_cap[fid] & NVME_FEAT_CAP_SAVE)) {
return NVME_FID_NOT_SAVEABLE | NVME_DNR;
}

Expand Down

0 comments on commit 0065f42

Please sign in to comment.