Skip to content

Commit

Permalink
tests/qtest/usb-hcd: Remove the empty "init" tests
Browse files Browse the repository at this point in the history
These tests do nothing additional compared to the other test,
so let's remove the empty functions to avoid wasting some few
precious test cycles here.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  • Loading branch information
huth authored and Michael Tokarev committed Sep 8, 2023
1 parent 95eac43 commit 0084f68
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
5 changes: 0 additions & 5 deletions tests/qtest/usb-hcd-uhci-test.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@

static QOSState *qs;

static void test_uhci_init(void)
{
}

static void test_port(int port)
{
struct qhc uhci;
Expand Down Expand Up @@ -71,7 +67,6 @@ int main(int argc, char **argv)
return 0;
}

qtest_add_func("/uhci/pci/init", test_uhci_init);
qtest_add_func("/uhci/pci/port1", test_port_1);
qtest_add_func("/uhci/pci/hotplug", test_uhci_hotplug);
if (qtest_has_device("usb-storage")) {
Expand Down
6 changes: 0 additions & 6 deletions tests/qtest/usb-hcd-xhci-test.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@
#include "libqtest-single.h"
#include "libqos/usb.h"


static void test_xhci_init(void)
{
}

static void test_xhci_hotplug(void)
{
usb_test_hotplug(global_qtest, "xhci", "1", NULL);
Expand Down Expand Up @@ -54,7 +49,6 @@ int main(int argc, char **argv)

g_test_init(&argc, &argv, NULL);

qtest_add_func("/xhci/pci/init", test_xhci_init);
qtest_add_func("/xhci/pci/hotplug", test_xhci_hotplug);
if (qtest_has_device("usb-uas")) {
qtest_add_func("/xhci/pci/hotplug/usb-uas", test_usb_uas_hotplug);
Expand Down

0 comments on commit 0084f68

Please sign in to comment.