Skip to content

Commit

Permalink
target/openrisc: Convert to 3-phase reset
Browse files Browse the repository at this point in the history
Convert the openrisc CPU class to use 3-phase reset, so it doesn't
need to use device_class_set_parent_reset() any more.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Edgar E. Iglesias <edgar@zeroasic.com>
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Message-id: 20221124115023.2437291-13-peter.maydell@linaro.org
  • Loading branch information
pm215 committed Dec 16, 2022
1 parent 4245a71 commit 0409750
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
12 changes: 8 additions & 4 deletions target/openrisc/cpu.c
Expand Up @@ -70,13 +70,15 @@ static void openrisc_disas_set_info(CPUState *cpu, disassemble_info *info)
info->print_insn = print_insn_or1k;
}

static void openrisc_cpu_reset(DeviceState *dev)
static void openrisc_cpu_reset_hold(Object *obj)
{
CPUState *s = CPU(dev);
CPUState *s = CPU(obj);
OpenRISCCPU *cpu = OPENRISC_CPU(s);
OpenRISCCPUClass *occ = OPENRISC_CPU_GET_CLASS(cpu);

occ->parent_reset(dev);
if (occ->parent_phases.hold) {
occ->parent_phases.hold(obj);
}

memset(&cpu->env, 0, offsetof(CPUOpenRISCState, end_reset_fields));

Expand Down Expand Up @@ -229,10 +231,12 @@ static void openrisc_cpu_class_init(ObjectClass *oc, void *data)
OpenRISCCPUClass *occ = OPENRISC_CPU_CLASS(oc);
CPUClass *cc = CPU_CLASS(occ);
DeviceClass *dc = DEVICE_CLASS(oc);
ResettableClass *rc = RESETTABLE_CLASS(oc);

device_class_set_parent_realize(dc, openrisc_cpu_realizefn,
&occ->parent_realize);
device_class_set_parent_reset(dc, openrisc_cpu_reset, &occ->parent_reset);
resettable_class_set_parent_phases(rc, NULL, openrisc_cpu_reset_hold, NULL,
&occ->parent_phases);

cc->class_by_name = openrisc_cpu_class_by_name;
cc->has_work = openrisc_cpu_has_work;
Expand Down
4 changes: 2 additions & 2 deletions target/openrisc/cpu.h
Expand Up @@ -34,7 +34,7 @@ OBJECT_DECLARE_CPU_TYPE(OpenRISCCPU, OpenRISCCPUClass, OPENRISC_CPU)
/**
* OpenRISCCPUClass:
* @parent_realize: The parent class' realize handler.
* @parent_reset: The parent class' reset handler.
* @parent_phases: The parent class' reset phase handlers.
*
* A OpenRISC CPU model.
*/
Expand All @@ -44,7 +44,7 @@ struct OpenRISCCPUClass {
/*< public >*/

DeviceRealize parent_realize;
DeviceReset parent_reset;
ResettablePhases parent_phases;
};

#define TARGET_INSN_START_EXTRA_WORDS 1
Expand Down

0 comments on commit 0409750

Please sign in to comment.