Skip to content

Commit

Permalink
migration: Initialize and cleanup decompression in migration.c
Browse files Browse the repository at this point in the history
This fixes compress with colo.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
  • Loading branch information
Lukey3332 authored and Juan Quintela committed Apr 28, 2023
1 parent 5766ce8 commit 05ecac6
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
9 changes: 9 additions & 0 deletions migration/migration.c
Expand Up @@ -26,6 +26,7 @@
#include "sysemu/cpu-throttle.h"
#include "rdma.h"
#include "ram.h"
#include "ram-compress.h"
#include "migration/global_state.h"
#include "migration/misc.h"
#include "migration.h"
Expand Down Expand Up @@ -228,6 +229,7 @@ void migration_incoming_state_destroy(void)
struct MigrationIncomingState *mis = migration_incoming_get_current();

multifd_load_cleanup();
compress_threads_load_cleanup();

if (mis->to_src_file) {
/* Tell source that we are done */
Expand Down Expand Up @@ -500,6 +502,12 @@ process_incoming_migration_co(void *opaque)
Error *local_err = NULL;

assert(mis->from_src_file);

if (compress_threads_load_setup(mis->from_src_file)) {
error_report("Failed to setup decompress threads");
goto fail;
}

mis->migration_incoming_co = qemu_coroutine_self();
mis->largest_page_size = qemu_ram_pagesize_largest();
postcopy_state_set(POSTCOPY_INCOMING_NONE);
Expand Down Expand Up @@ -565,6 +573,7 @@ process_incoming_migration_co(void *opaque)
qemu_fclose(mis->from_src_file);

multifd_load_cleanup();
compress_threads_load_cleanup();

exit(EXIT_FAILURE);
}
Expand Down
5 changes: 0 additions & 5 deletions migration/ram.c
Expand Up @@ -3558,10 +3558,6 @@ void colo_release_ram_cache(void)
*/
static int ram_load_setup(QEMUFile *f, void *opaque)
{
if (compress_threads_load_setup(f)) {
return -1;
}

xbzrle_load_setup();
ramblock_recv_map_init();

Expand All @@ -3577,7 +3573,6 @@ static int ram_load_cleanup(void *opaque)
}

xbzrle_load_cleanup();
compress_threads_load_cleanup();

RAMBLOCK_FOREACH_NOT_IGNORED(rb) {
g_free(rb->receivedmap);
Expand Down

0 comments on commit 05ecac6

Please sign in to comment.