Skip to content

Commit

Permalink
target-*: Clean up cpu.h header guards
Browse files Browse the repository at this point in the history
Most of them use guard symbols like CPU_$target_H, but we also have
__MIPS_CPU_H__ and __TRICORE_CPU_H__.  They all upset
scripts/clean-header-guards.pl.

The script dislikes CPU_$target_H because they don't match their file
name (they should, to make guard collisions less likely).  The others
are reserved identifiers.

Clean them all up: use guard symbol $target_CPU_H for
target-$target/cpu.h.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Richard Henderson <rth@twiddle.net>
  • Loading branch information
Markus Armbruster committed Jul 12, 2016
1 parent 2dbc4eb commit 07f5a25
Show file tree
Hide file tree
Showing 18 changed files with 56 additions and 45 deletions.
6 changes: 3 additions & 3 deletions target-alpha/cpu.h
Expand Up @@ -17,8 +17,8 @@
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/

#if !defined (__CPU_ALPHA_H__)
#define __CPU_ALPHA_H__
#ifndef ALPHA_CPU_H
#define ALPHA_CPU_H

#include "qemu-common.h"
#include "cpu-qom.h"
Expand Down Expand Up @@ -524,4 +524,4 @@ static inline void cpu_get_tb_cpu_state(CPUAlphaState *env, target_ulong *pc,
*pflags = flags;
}

#endif /* !defined (__CPU_ALPHA_H__) */
#endif /* ALPHA_CPU_H */
4 changes: 2 additions & 2 deletions target-arm/cpu.h
Expand Up @@ -16,9 +16,9 @@
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#ifndef CPU_ARM_H
#define CPU_ARM_H

#ifndef ARM_CPU_H
#define ARM_CPU_H

#include "kvm-consts.h"

Expand Down
5 changes: 3 additions & 2 deletions target-cris/cpu.h
Expand Up @@ -17,8 +17,9 @@
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#ifndef CPU_CRIS_H
#define CPU_CRIS_H

#ifndef CRIS_CPU_H
#define CRIS_CPU_H

#include "qemu-common.h"
#include "cpu-qom.h"
Expand Down
7 changes: 4 additions & 3 deletions target-i386/cpu.h
Expand Up @@ -16,8 +16,9 @@
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#ifndef CPU_I386_H
#define CPU_I386_H

#ifndef I386_CPU_H
#define I386_CPU_H

#include "qemu-common.h"
#include "cpu-qom.h"
Expand Down Expand Up @@ -1607,4 +1608,4 @@ void x86_cpu_dump_local_apic_state(CPUState *cs, FILE *f,
/* cpu.c */
bool cpu_is_bsp(X86CPU *cpu);

#endif /* CPU_I386_H */
#endif /* I386_CPU_H */
4 changes: 2 additions & 2 deletions target-lm32/cpu.h
Expand Up @@ -17,8 +17,8 @@
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/

#ifndef CPU_LM32_H
#define CPU_LM32_H
#ifndef LM32_CPU_H
#define LM32_CPU_H

#define TARGET_LONG_BITS 32

Expand Down
5 changes: 3 additions & 2 deletions target-m68k/cpu.h
Expand Up @@ -17,8 +17,9 @@
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#ifndef CPU_M68K_H
#define CPU_M68K_H

#ifndef M68K_CPU_H
#define M68K_CPU_H

#define TARGET_LONG_BITS 32

Expand Down
5 changes: 3 additions & 2 deletions target-microblaze/cpu.h
Expand Up @@ -16,8 +16,9 @@
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#ifndef CPU_MICROBLAZE_H
#define CPU_MICROBLAZE_H

#ifndef MICROBLAZE_CPU_H
#define MICROBLAZE_CPU_H

#include "qemu-common.h"
#include "cpu-qom.h"
Expand Down
6 changes: 3 additions & 3 deletions target-mips/cpu.h
@@ -1,5 +1,5 @@
#if !defined (__MIPS_CPU_H__)
#define __MIPS_CPU_H__
#ifndef MIPS_CPU_H
#define MIPS_CPU_H

//#define DEBUG_OP

Expand Down Expand Up @@ -1066,4 +1066,4 @@ static inline void QEMU_NORETURN do_raise_exception(CPUMIPSState *env,
do_raise_exception_err(env, exception, 0, pc);
}

#endif /* !defined (__MIPS_CPU_H__) */
#endif /* MIPS_CPU_H */
7 changes: 4 additions & 3 deletions target-moxie/cpu.h
Expand Up @@ -16,8 +16,9 @@
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#ifndef _CPU_MOXIE_H
#define _CPU_MOXIE_H

#ifndef MOXIE_CPU_H
#define MOXIE_CPU_H

#include "qemu-common.h"

Expand Down Expand Up @@ -139,4 +140,4 @@ static inline void cpu_get_tb_cpu_state(CPUMoxieState *env, target_ulong *pc,
int moxie_cpu_handle_mmu_fault(CPUState *cpu, vaddr address,
int rw, int mmu_idx);

#endif /* _CPU_MOXIE_H */
#endif /* MOXIE_CPU_H */
6 changes: 3 additions & 3 deletions target-openrisc/cpu.h
Expand Up @@ -17,8 +17,8 @@
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/

#ifndef CPU_OPENRISC_H
#define CPU_OPENRISC_H
#ifndef OPENRISC_CPU_H
#define OPENRISC_CPU_H

#define TARGET_LONG_BITS 32

Expand Down Expand Up @@ -408,4 +408,4 @@ static inline int cpu_mmu_index(CPUOpenRISCState *env, bool ifetch)

#define CPU_INTERRUPT_TIMER CPU_INTERRUPT_TGT_INT_0

#endif /* CPU_OPENRISC_H */
#endif /* OPENRISC_CPU_H */
7 changes: 4 additions & 3 deletions target-ppc/cpu.h
Expand Up @@ -16,8 +16,9 @@
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#if !defined (__CPU_PPC_H__)
#define __CPU_PPC_H__

#ifndef PPC_CPU_H
#define PPC_CPU_H

#include "qemu-common.h"

Expand Down Expand Up @@ -2432,4 +2433,4 @@ int ppc_get_vcpu_dt_id(PowerPCCPU *cpu);
PowerPCCPU *ppc_get_vcpu_by_dt_id(int cpu_dt_id);

void ppc_maybe_bswap_register(CPUPPCState *env, uint8_t *mem_buf, int len);
#endif /* !defined (__CPU_PPC_H__) */
#endif /* PPC_CPU_H */
5 changes: 3 additions & 2 deletions target-s390x/cpu.h
Expand Up @@ -19,8 +19,9 @@
* You should have received a copy of the GNU (Lesser) General Public
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#ifndef CPU_S390X_H
#define CPU_S390X_H

#ifndef S390X_CPU_H
#define S390X_CPU_H

#include "qemu-common.h"
#include "cpu-qom.h"
Expand Down
7 changes: 4 additions & 3 deletions target-sh4/cpu.h
Expand Up @@ -16,8 +16,9 @@
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#ifndef _CPU_SH4_H
#define _CPU_SH4_H

#ifndef SH4_CPU_H
#define SH4_CPU_H

#include "qemu-common.h"
#include "cpu-qom.h"
Expand Down Expand Up @@ -387,4 +388,4 @@ static inline void cpu_get_tb_cpu_state(CPUSH4State *env, target_ulong *pc,
| (env->movcal_backup ? TB_FLAG_PENDING_MOVCA : 0); /* Bit 4 */
}

#endif /* _CPU_SH4_H */
#endif /* SH4_CPU_H */
4 changes: 2 additions & 2 deletions target-sparc/cpu.h
@@ -1,5 +1,5 @@
#ifndef CPU_SPARC_H
#define CPU_SPARC_H
#ifndef SPARC_CPU_H
#define SPARC_CPU_H

#include "qemu-common.h"
#include "qemu/bswap.h"
Expand Down
5 changes: 3 additions & 2 deletions target-tilegx/cpu.h
Expand Up @@ -16,8 +16,9 @@
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#ifndef CPU_TILEGX_H
#define CPU_TILEGX_H

#ifndef TILEGX_CPU_H
#define TILEGX_CPU_H

#include "qemu-common.h"

Expand Down
7 changes: 4 additions & 3 deletions target-tricore/cpu.h
Expand Up @@ -16,8 +16,9 @@
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#if !defined(__TRICORE_CPU_H__)
#define __TRICORE_CPU_H__

#ifndef TRICORE_CPU_H
#define TRICORE_CPU_H

#include "tricore-defs.h"
#include "qemu-common.h"
Expand Down Expand Up @@ -420,4 +421,4 @@ int cpu_tricore_handle_mmu_fault(CPUState *cpu, target_ulong address,
int rw, int mmu_idx);
#define cpu_handle_mmu_fault cpu_tricore_handle_mmu_fault

#endif /*__TRICORE_CPU_H__ */
#endif /* TRICORE_CPU_H */
7 changes: 4 additions & 3 deletions target-unicore32/cpu.h
Expand Up @@ -8,8 +8,9 @@
* published by the Free Software Foundation, or (at your option) any
* later version. See the COPYING file in the top-level directory.
*/
#ifndef QEMU_UNICORE32_CPU_H
#define QEMU_UNICORE32_CPU_H

#ifndef UNICORE32_CPU_H
#define UNICORE32_CPU_H

#define TARGET_LONG_BITS 32
#define TARGET_PAGE_BITS 12
Expand Down Expand Up @@ -184,4 +185,4 @@ int uc32_cpu_handle_mmu_fault(CPUState *cpu, vaddr address, int rw,
void uc32_translate_init(void);
void switch_mode(CPUUniCore32State *, int);

#endif /* QEMU_UNICORE32_CPU_H */
#endif /* UNICORE32_CPU_H */
4 changes: 2 additions & 2 deletions target-xtensa/cpu.h
Expand Up @@ -25,8 +25,8 @@
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

#ifndef CPU_XTENSA_H
#define CPU_XTENSA_H
#ifndef XTENSA_CPU_H
#define XTENSA_CPU_H

#define ALIGNED_ONLY
#define TARGET_LONG_BITS 32
Expand Down

0 comments on commit 07f5a25

Please sign in to comment.